Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix paragraph on how do the variants and accented tables work #38577

Merged
merged 1 commit into from May 11, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 9, 2023

Description

This PR suggests some changes after 5400415:

  • Display custom properties as --bs instead of --#{$prefix} because apart from CSS shortcodes, this is generally how we talk about them in the documentation
  • Fix *-bg--state and *-bg--type that have a double dash

IMO this PR should be integrated into the v5.3.0 since coming from a new change in v5.3.0. CC @mdo

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review May 9, 2023 13:23
@mdo mdo merged commit 7d97fdf into main May 11, 2023
15 checks passed
@mdo mdo deleted the main-jd-fix-tables-markdown-docs branch May 11, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants