Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: add back v5.0.0 heading #39060

Merged
merged 5 commits into from Aug 21, 2023
Merged

Migration: add back v5.0.0 heading #39060

merged 5 commits into from Aug 21, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 15, 2023 •
edited

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR changed the title Migrations: add back v5.0.0 heading Migration: add back v5.0.0 heading Aug 15, 2023
@XhmikosR XhmikosR added the docs label Aug 15, 2023
@XhmikosR XhmikosR marked this pull request as ready for review August 15, 2023 11:38
@XhmikosR XhmikosR requested a review from mdo August 15, 2023 11:38
@julien-deramond
Copy link
Member

Good catch.
I'd say that sub-headers like "Dependencies", "Browser support", etc. should now be <h3> instead of <h2> (should be within "v5.0.0"). Now they are at the same level:
Screenshot 2023-08-21 at 08 42 09

@XhmikosR
Copy link
Member Author

Ah, true. I'll fix it later unless someone else can quickly make the change :)

@XhmikosR XhmikosR merged commit 47da803 into main Aug 21, 2023
15 checks passed
@XhmikosR XhmikosR deleted the xmr/migration branch August 21, 2023 07:49
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@XhmikosR @romankupchak93
Migration: add back v5.0.0 heading (twbs#39060)
acc107c 
* Migrations: add back v5.0.0 heading

* Update migration.md

* Update migration.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.3.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @julien-deramond