CI: stop running coveralls in forks #39096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this will work for PRs... It probably won't. My plan is to stop this from running when we are not on our repo or a PR against our repo. |
.github/workflows/js.yml
Outdated
| @@ -46,6 +46,7 @@ jobs: | |||
|
|
|||
| - name: Run Coveralls | |||
| uses: coverallsapp/github-action@v2 | |||
| if: github.repository == 'twbs/bootstrap' | |||
There was a problem hiding this comment.
Maybe both are working but I've seen and used another approach to do that:
Suggested change
| if: github.repository == 'twbs/bootstrap' | |
| if: github.repository_owner == 'twbs' |
If I remember well, the job starts but is canceled because of the condition.
There was a problem hiding this comment.
I think we could probably just use this too:
if: ${{ !github.event.repository.fork }}
XhmikosR
changed the title
louismaximepiton
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.