Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add dispose() to Offcanvas methods #39340

Merged
merged 1 commit into from Oct 30, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 28, 2023

Description

This PR simply adds the dispose() function to the Offcanvas methods list in the documentation.

Type of changes

  • Documentation fix

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39339

@julien-deramond julien-deramond changed the title Doc: add dispose() to Offcanvas and fix typo for List Group Doc: add dispose() to Offcanvas methods Oct 28, 2023
@julien-deramond julien-deramond marked this pull request as ready for review October 28, 2023 12:54
@julien-deramond julien-deramond merged commit d769ae0 into main Oct 30, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-add-dispose-to-offcanvas branch October 30, 2023 07:23
priyashpatil pushed a commit to priyashpatil/bootstrap that referenced this pull request Nov 8, 2023
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing "dispose" method for Offcanvas in Documentation
2 participants