Fix color schemes description in Sass customization documentation #39417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mdo
approved these changes
Nov 18, 2023
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the description of the "Color schemes" contained in "Customize > Sass" documentation page.
As mentioned in the issue's discussion, Media Queries Level 5 spec mentions that the only values of
prefers-color-schemearelightanddark. So talking about custom values is wrong.I chose to avoid mentioning the fact that the spec says that the values might be expanded in the future:
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #39410