Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest a new feature - add breakpoints to ratios #39449

Open
2 tasks done
jellestekelenburg opened this issue Nov 29, 2023 · 2 comments
Open
2 tasks done

Suggest a new feature - add breakpoints to ratios #39449

jellestekelenburg opened this issue Nov 29, 2023 · 2 comments

Comments

@jellestekelenburg
Copy link

Prerequisites

Proposal

Ratios inside of bootstrap work fine but when you only want a certain ratio from lets say breakpoint-lg you're stuck in the styling of the .ratio class.

I suggest maybe redoing the whole ratio feature because of the new aspect-ratio propperty in css.

I'd love to atleast see a fix to have something like .ratio-lg to have the ratio class active from 992px

Motivation and context

It has become a roadblock and i've had to stop using th class altogether and create my own. Which isn't that bad but for something like Bootstrap you would like this to work out of the box.

@royGarima1518
Copy link

royGarima1518 commented Nov 29, 2023

@media (min-width: 992px) {
  .ratio-lg {
    --#{$prefix}aspect-ratio:  @#{$large-screen-ratio};
  }
}

@mdo mdo added the v6 label Dec 9, 2023
@mdo
Copy link
Member

mdo commented Dec 9, 2023

Will come with v6 when we move ratio to utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants