Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use consistent HTML elements in Utilities > Background page #39519

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 21, 2023

Description

This PR brings more consistency to our Utilities > Background page by using the same HTML element everywhere for the same rendering.

@patrickhlauke I've used <div>s because the entire page was already using mostly <div>s. However, I'm wondering, in terms of documentation accessibility, if it wouldn't be better to use <p>s instead everywhere. What do you think?

Motivation & Context

Consistency.

Type of changes

  • Docs refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@patrickhlauke
Copy link
Member

However, I'm wondering, in terms of documentation accessibility, if it wouldn't be better to use <p>s instead everywhere. What do you think?

won't make any practical difference, so this is good to go

@julien-deramond julien-deramond merged commit 00317d2 into main Dec 22, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-consistent-utilities-background-html-elements branch December 22, 2023 06:14
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants