Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Fix modal on mobile chromium based browsers #39739

Merged
merged 2 commits into from Mar 8, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 5, 2024

Description

Set the position to have always the same.

Motivation & Context

Some issue on mobile breakpoint when using Chrome or Chromium based with search modal from Algolia.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #39665.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The position: fixed doesn't seem to imply some visual regressions and it fixes the issue that was reproducible on basically all browsers on my side.

@julien-deramond julien-deramond merged commit f545964 into main Mar 8, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-algolia-chrome-fix branch March 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Button not responding
2 participants