Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_grid.scss .row > * impacts on many blocks and regions #39946

Closed
3 tasks done
webprogrammierer opened this issue May 1, 2024 · 7 comments
Closed
3 tasks done

_grid.scss .row > * impacts on many blocks and regions #39946

webprogrammierer opened this issue May 1, 2024 · 7 comments

Comments

@webprogrammierer
Copy link

Prerequisites

Describe the issue

This code in _grid.scss

@if $enable-grid-classes {
  .row {
    @include make-row();

    > * {
      @include make-col-ready();
    }
  }
}

impacts on many block, regions and other elements having the. row class.

The code results in the following CSS:

.row > * {
    flex-shrink: 0;
    width: 100%;
    max-width: 100%;
    padding-right: calc(var(--bs-gutter-x)* 0.5);
    padding-left: calc(var(--bs-gutter-x)* 0.5);
    margin-top: var(--bs-gutter-y);
}

Is is a really bad idea to use .row > * without any .grid class.
On thausends of sites this leads to necessary but not easy CSS adjustments on a lot of blocks, elements, regions which use the .row class.

Can you plesae remove / adapt these lines and to ensure they does not result in .row > * ?

Thank you.

Reduced test cases

<section class="row region region-menu">
     <a href="/" title="Startseite" rel="home" class="navbar-brand">
           <img src="/themes/custom/xxxx/logo.svg" alt="" class="img-fluid d-inline-block align-top">
            <span class="ml-2 d-none d-md-inline"></span>
    </a>
    <nav role="navigation" aria-labelledby="block-mainnavigation-menu" id="block-mainnavigation" class="contextual-region block block-menu navigation col-12 menu--main">
     ...
   </nav>
   <div class="search-block-form contextual-region block block-search block-search-form-block" data-drupal-selector="search-block-form" id="block-searchform" role="search">
     ....
   </div>
</section>

What operating system(s) are you seeing the problem on?

Windows, Linux

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

v5.3.3

@webprogrammierer webprogrammierer changed the title _grid.scss .row > * impact on many blocks and regions _grid.scss .row > * impacts on many blocks and regions May 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello @webprogrammierer. Bug reports must include a live demo of the issue. Per our contributing guidelines, please create a reduced test case on CodePen or StackBlitz and report back with your link, Bootstrap version, and specific browser and Operating System details.

@webprogrammierer
Copy link
Author

This is browser independent as you can see.

Anybody can see, that using

.row > * {
}

is a great problem!

@julien-deramond
Copy link
Member

Hello @webprogrammierer
If possible on your side, you've mentioned a reduced test case in the description. Could you please transform it to a live demo with CodePen, StackBlitz, or any other tools? It saves us a lot of time.

@webprogrammierer
Copy link
Author

For this problem

.row > * {
}

there is no demo necessary. Everybody can see the problem immeditally. This will impact on thausands of sites with different effects.

@mdo
Copy link
Member

mdo commented May 2, 2024

No changes planned here.

@mdo mdo closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
@webprogrammierer
Copy link
Author

Hello @mdo .
Why no changes if it impacts thausends of sites with massive layout effects?

@webprogrammierer
Copy link
Author

I am sure, this will be changed in one of the next releases.
Why not do it just now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants