Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input group with nested dropdown differs from btn group #40483

Open
2 tasks done
VividLemon opened this issue May 23, 2024 · 0 comments
Open
2 tasks done

input group with nested dropdown differs from btn group #40483

VividLemon opened this issue May 23, 2024 · 0 comments
Labels

Comments

@VividLemon
Copy link
Contributor

Prerequisites

Proposal

https://getbootstrap.com/docs/5.3/components/button-group/#nesting

https://getbootstrap.com/docs/5.3/forms/input-group/#buttons-with-dropdowns

button can render a nested div while input groups cannot. It's not that they can, they are not allowed to otherwise it breaks the class.

Since there is no wrapper div, I'm not sure how one would apply https://getbootstrap.com/docs/5.3/components/dropdowns/#directions

I'm not sure if technically this is feasible, I've seen remarks about input group being an annoying class to deal with.

Motivation and context

Originally the issue stemmed from https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/main/packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue#L2

We always render a wrapping div here to protect Vue directives. However, due to this constraint, I think we may need to render a fragment. Which has drawbacks. Practically I don't think there is significant usage with directives to need some hacky implementation, with the best solution on our end just being to render a fragment.

There is also the question on how to render those direction classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant