Fade disabled buttons into luminance-gray color of current plane background #40559
+62
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lor via `var()`-name in `.bg-<COLOR>` classes
```css
body {
--bs-current-plane-bg: var(--bs-body-bg);
}
.bg-primary {
--bs-current-plane-bg: var(--bs-primary);
}
.bg-secondary {
--bs-current-plane-bg: var(--bs-secondary);
}
.bg-success {
--bs-current-plane-bg: var(--bs-success);
}
[…]
```
…ground ### Before: Disabled buttons simply used `opacity` and color-cross-fading happened. E.g. a disabled red button on a blue plane became purple. ### With this change: Disabled buttons color is mixed with a gray having the identical luminance as the background-color. This results in the following color change of disabled buttons. #### Lightness: Lightened on light background and darkened on dark background. In comparison: Identical behaviour as before. Buttons lightness is slightly (`fade-percentage`) fading into the background. #### Saturation: Slightly desaturated. In comparison: On black/white gray background: Identical behaviour as before. On colorful background: Before there was an unintentional mix between bg-color and button-color saturation. Now the button is simply slightly (`fade-percentage`) desaturated. #### Hue Stays identical. In comparison: On black/white gray background: Identical behaviour as before. On colorful background: Before there was an unintentional cross-fading between bg-color and button-color resulting in unfortunate dyeing of the button. Now the button keeps its color hue.
…r that might contain buttons
rr-it
force-pushed
the
feature/button-gray-fade
branch
from
faa19cb
to
6a48cf0
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fade disabled buttons into luminance-gray color of current plane background.
Disabled buttons color is mixed with a gray having the identical luminance as the background-color. This results in the following color change of disabled buttons.
https://codepen.io/rr-it/pen/LYoOKrx
https://codepen.io/rr-it/pen/jOoYVMm
Lightness:
Lightened on light background and darkened on dark background.
In comparison:
Identical behaviour as before. Buttons lightness is slightly (
fade-percentage) fading into the background.Saturation:
Slightly desaturated.
In comparison:
On black/white gray background: Identical behaviour as before.
On colorful background: Before there was an unintentional mix between bg-color and button-color saturation. Now the button is simply slightly (
fade-percentage) desaturated.Hue:
Stays identical.
In comparison:
On black/white gray background: Identical behaviour as before.
On colorful background: Before there was an unintentional cross-fading between bg-color and button-color resulting in unfortunate dyeing of the button. Now the button keeps its color hue.
Introduction of new css-var
--bs-current-plane-bgThis introduces the css-var
--bs-current-plane-bgto hold a reference to the bg-color of the current plane.Motivation:
inheritis currently not usable inside CSS functions. See w3c/csswg-drafts#9757This css-var is set in
body-tag.bg-<COLOR>classesThis css-var should also be set for custom elements that set their own background-color.
Motivation & Context
Before disabled buttons simply used
opacityand color-cross-fading happened.E.g. a disabled red button on a blue plane became purple.
More real world example:
Gray disabled button in a button-group on selected row with blue background:
This 'disabled' button has a blueish look and thereby looks somehow activated.
Type of changes
Checklist
npm run lint)Live previews
@deploy-preview-40559)@5.3.3)Related issues
Resolves #40557