Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] 'ip' dependency package flagged with high security advisory flag #40561

Open
3 tasks done
peterblazejewicz opened this issue Jun 16, 2024 · 0 comments
Open
3 tasks done
Assignees

Comments

@peterblazejewicz
Copy link
Contributor

Prerequisites

Describe the issue

The development of the BS dev dependency, ip package, seems to cease for good:
https://github.com/indutny/node-ip
and (the package) it's now being flagged as a high issue during audit run when using NPM package manager:
GHSA-2p57-rm9w-gvfp

that is not a problem with BS itself, but some white sourcing tolls are to mark setups as vulnerable, depending on configuration (I assume company where I work, this will happen on first clean install after cache in the pipeline is evicted with any package-lock.json update).

Solution:

  • remove ip dependency completely, it looks as being used only for Karma runner configuration when run in BrowserStack context (and this one is either localhost or run on the BrowserStack in-house CI tool). It looks BrowserStack action has been disabled anyway in BS
  • replace the lookup code with inline code or another dependency.

I assume removing ip lookup code and just using Karma configuration defaults (localhost) would be enough,

thanks!

note: not a security issue with BS itself, so the 'SECURITY' submission path was not used

Reduced test cases

n/a

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Safari

What version of Bootstrap are you using?

5.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants