Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of deprecated dark variants examples #40566

Open
3 tasks done
carlosmintfan opened this issue Jun 19, 2024 · 1 comment · May be fixed by #39291
Open
3 tasks done

Inconsistent handling of deprecated dark variants examples #40566

carlosmintfan opened this issue Jun 19, 2024 · 1 comment · May be fixed by #39291

Comments

@carlosmintfan
Copy link

Prerequisites

Describe the issue

I’ve detected that the docs are providing the example code for the dark variants in two different, inconsistent ways: Some components still show the old code after the deprecated warning while others show the warning and then directly the new code using the color modes feature. I suggest showing both for maximum clarity and ease of copying and clearly state which one is deprecated and which one is recommended.
Note that the "deprecated" badge at the examples showing the new (not deprecated!) code could be a bit misleading or "making sad" without reading the callout.

Reduced test cases

https://getbootstrap.com/docs/5.3/components/dropdowns/#dark-dropdowns using the old variant class
https://getbootstrap.com/docs/5.3/components/navbar/#color-schemes using new code
https://getbootstrap.com/docs/5.3/components/navbar/#color-schemes using new code
And possibly more…

What operating system(s) are you seeing the problem on?

Windows, macOS, Android, iOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari, Firefox, Microsoft Edge, Opera

What version of Bootstrap are you using?

5.3.3

@julien-deramond
Copy link
Member

Thanks for reporting this issue @carlosmintfan
There was no issue in the backlog, but #39291 already existed trying to tackle it
So let's keep your issue as a reference, and link #39291 to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in progress
Development

Successfully merging a pull request may close this issue.

2 participants