fixes #5494: style invalid fields as invalid regardless of required-ness #5786
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
added a commit
that referenced
this pull request
Nov 5, 2012
fixes #5494: style invalid fields as invalid regardless of required-ness
mdo
added a commit
that referenced
this pull request
Jan 12, 2013
update 3.0.0 docs to reflect #5786
mdo
added a commit
that referenced
this pull request
Jan 12, 2013
update 2.3.0 docs to reflect #5786
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
fixes twbs#5494: style invalid fields as invalid regardless of required-ness
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
fixes twbs#5494: style invalid fields as invalid regardless of required-ness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The obvious, simple fix for #5494. Removes the
:requiredselectors from the:invalidstyles so that optional fields with invalid values also get styled.The commit which originally introduced these styles (1209a37) does not explain the inclusion of the
requireds, nor does the blog post to which it links (said post instead justifies the:focuses), so the exclusion of optional fields doesn't seem to have been deliberate / explicitly-intended.