Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #6472

Merged
merged 1 commit into from Jan 12, 2013
Merged

Update composer.json #6472

merged 1 commit into from Jan 12, 2013

Conversation

RWOverdijk
Copy link
Contributor

target-dir is not needed. All it does, is nest everything another level deeper. It should only be used for completing psr-0 paths.

target-dir is not needed. All it does, is nest everything another level deeper. It should only be used for completing psr-0 paths.
@igorw
Copy link

igorw commented Jan 6, 2013

👍 I'm surprised I haven't seen any complaints about this.

mdo added a commit that referenced this pull request Jan 12, 2013
@mdo mdo merged commit e195457 into twbs:2.3.0-wip Jan 12, 2013
@RWOverdijk RWOverdijk deleted the patch-1 branch January 19, 2013 18:00
@localheinz
Copy link

Seems like it has been fixed some time ago.

But the directories have appeared again. Can someone have a look at this?

@RWOverdijk
Copy link
Contributor Author

@localheinz Which branch?

@localheinz
Copy link

@RWOverdijk

In composer.json I require

"twitter/bootstrap": "v2.3.0",

and then this happens:

Screen Shot 2013-02-25 at 2 34 35 PM

@igorw
Copy link

igorw commented Feb 25, 2013

Cannot reproduce.

@RWOverdijk
Copy link
Contributor Author

@igorw @localheinz It took me a while, but I reproduced it.

  • Install 2.2.2 (setting back the wrong dir tree)
  • Update composer.json to 2.3.0
  • Run composer update. (Expect dir tree to chance)
  • Same dir structure. (Be disappointed with same dir tree)

@localheinz It would have helped if you'd included this information, too. To fix this, just remove vendor/twitter and run install again. It won't do matching tag-magic and you'll have your new tree structure.

@localheinz
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants