Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollspy - Issues with 100% body height in FF/Opera #6484

Closed
drainpip opened this issue Jan 7, 2013 · 12 comments
Closed

Scrollspy - Issues with 100% body height in FF/Opera #6484

drainpip opened this issue Jan 7, 2013 · 12 comments
Labels

Comments

@drainpip
Copy link

drainpip commented Jan 7, 2013

I have included a jsfiddle with a basic example of the issue. When using 100% height on the body, Firefox breaks up using scrollspy. Unfortunately for me, my design requires a sticky footer.

  • Works in Chrome / IE / Safari
  • Broken in FF / Opera
  • Removing 100% body height fixes issue
  • Tested in latest version of each browser

Here is the jsfiddle: http://jsfiddle.net/drainpip/mGWVy/

@boulox
Copy link
Contributor

boulox commented Jan 9, 2013

Nice catch. i can reproduce the same on my mac from the jsfiffle and from live customer website :/
Hope will have a fix soon

@drainpip
Copy link
Author

I was able to get it to work 95% using this commit from @p2000

Pfiver@7e286a7

This, however, creates the problem if the section ID isn't long enough to match up with the side nav the li won't addClass active. I'll keep this solution on my build at least temporarily until I can think up anything else to do or abandon it for another solution.

@drainpip
Copy link
Author

I just added this into my JS to make the top of the section always hit the top of the viewport on pages using scrollspy with an affixed menu.

https://gist.github.com/4560823

@fat
Copy link
Member

fat commented Feb 8, 2013

just don't use it with height 100% on the body

@fat fat closed this as completed Feb 8, 2013
@raphaotten
Copy link

So you mean you can't use a sticky footer together with scrollspy?
Even the Bootstrap example for a sticky footer uses 100% height on the body: http://twitter.github.com/bootstrap/examples/sticky-footer.html

@boulox
Copy link
Contributor

boulox commented Feb 8, 2013

agree +1 to reopen the issue. Until 100% height on body is required for sticky footer. Scrollspy should support it.

I believe scroll spy is not a widely use plugin and here you reduce again the ability to use it from already a small amount of people could be interesting at using it. It's start to be a pretty useless...

@drainpip
Copy link
Author

drainpip commented Feb 8, 2013

Even though the devs have no interest in fixing it, the hacks listed above do work if your project requires both.

@wolfgangrittner
Copy link

+1 for reopen! or are you really just telling us "you're scrolling it wrong"? ;-)

@Gorgoroth
Copy link

It'd be nice to see this resolved, please reopen.

Unless there's an alternative for Sticky Footers.

@drainpip
Copy link
Author

#5007 (comment)

There's an easy way to update it. I am using this + https://gist.github.com/4560823 to get the effect I want.

@noniq
Copy link

noniq commented May 23, 2013

The patch from #7315 (applied to 2.3.2) fixes the problem for me in Firefox (while it still works correctly in other browsers).

@drainpip
Copy link
Author

Good to hear, I can confirm it's working for me in 2.3.2. I'll be testing BS3 beta soon if it was committed there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants