Fix tooltip positioning for IE8 broken in 2.3.0 #6737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE8 defines a placeholder object getBoundingClientRect which breaks the new getPosition() method
|
👍 |
fat
added a commit
that referenced
this pull request
Feb 6, 2013
…or-ie8 Fix tooltip positioning for IE8 broken in 2.3.0
|
rad dude, thanks! |
|
Tooltip positioning now doesn't work at all http://twitter.github.com/bootstrap/javascript.html#tooltips with 2.3.0 |
|
Indeed the |
|
See #6832. |
|
The regression isn't due to my pull request. It works like a charm with data-placement as we are using it. I think the regression is most likely related to this patch: 1fe4ed8#js/bootstrap-tooltip.js . The version we use here at work only has this commit missing and data-placement works flawlessly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE8 defines a broken placeholder object getBoundingClientRect which breaks the new getPosition() method introduced in 2.3.0
As height and width are not defined in the getPosition() result, tooltips aren't positioned correctly.
This pull request fixes #6659 .