Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .navbar-toggle to match other .navbar el #9040

Closed
wants to merge 1 commit into from
Closed

Update .navbar-toggle to match other .navbar el #9040

wants to merge 1 commit into from

Conversation

jholl
Copy link
Contributor

@jholl jholl commented Aug 3, 2013

Update .navbar-toggle styling to position dynamically within .navbar right padding, and to size/look more like a .btn element

  • change right: 10px to right: @navbar-padding-horizontal
  • change height: to 34px
  • change top: to calc basis new height
  • change padding: to match .btn el
  • could add dynamic calc for height and in calc of top, but not in this PR

+ change `right: 10px` to `right: @navbar-padding-horizontal`
+ change `height:` to 34px
+ change `top:` to calc basis new height
+ change `padding:` to match `.btn` el
+ could add dynamic calc for height and in calc of top
@jholl
Copy link
Contributor Author

jholl commented Aug 3, 2013

more in favor of #8844 using position: relative with float: right as it allows me to more easily extend a second .navbar-toggle button at the bottom of my responsive nav when open. Using new commit #9042.

stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
In place of commit twbs#9040, fix twbs#8844
And sizing .navbar-toggle more like .btn elem
+ change `position:absolute` to `position:relative`
+ remove `right: 10px` in favor of `float:right`
+ change to `height: 34px`
+ remove `top:` in favor of `.navbar-vertical-align` basis new height
+ change `padding:` to match `.btn` el
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
In place of commit twbs#9040, fix twbs#8844
And sizing .navbar-toggle more like .btn elem
+ change `position:absolute` to `position:relative`
+ remove `right: 10px` in favor of `float:right`
+ change to `height: 34px`
+ remove `top:` in favor of `.navbar-vertical-align` basis new height
+ change `padding:` to match `.btn` el
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant