BS3: .btn-groups for your .btn-groups
#9424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
added a commit
that referenced
this pull request
Aug 13, 2013
BS3: `.btn-group`s for your `.btn-group`s
|
Thanks for the explanation, much apreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9242—the inability to nest button groups in vertical button groups.
As a side note for @ggam, if we had added #9407 this wouldn't really be possible because we'd have to reset the original
border-radiusvalues that are required by the vertical group. The goal with how we wrote these is that we don't ever have to reset an original value, only zero out what needs zero-ing out. Hope that helps!