Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS3: Simpler row margins #9718

Merged
merged 1 commit into from
Aug 16, 2013
Merged

BS3: Simpler row margins #9718

merged 1 commit into from
Aug 16, 2013

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 16, 2013

This makes negative margins on rows the default, not just in containers, and adds padding to body to compensate for the negative margin on narrow viewports. Why do this?

  • Consistent row behavior across all viewports and grid tiers
  • Consistent row behavior within a variety of components that aren't containers
  • Simpler styling for completely fluid layouts (those that go edge to edge)

This would fix #9565, #9605, #9664, and a few other issues I believe.

mdo added a commit that referenced this pull request Aug 16, 2013
@mdo mdo merged commit 16d5e1b into 3.0.0-wip Aug 16, 2013
@mdo mdo deleted the bs3_row_margins branch August 16, 2013 22:32
@mdo
Copy link
Member Author

mdo commented Aug 17, 2013

Derp, fucked up the commit number but this should be better now via cd0df1d.

I placed the padding on the containers (and adjusted their widths accordingly) instead of the body. Should solve these problems you're running into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants