Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate property definitions #10979

Closed
ujovlado opened this issue Oct 8, 2013 · 3 comments
Closed

Duplicate property definitions #10979

ujovlado opened this issue Oct 8, 2013 · 3 comments
Labels
confirmed css
Milestone
v3.0.3

Comments

@ujovlado
Copy link

ujovlado commented Oct 8, 2013

Hi, I found two duplicate property set in exported CSS.
I don't know if it's the purpose or there's problem with LESS to CSS conversion.

/* line 3483, padding */

.btn-group-xs > .btn {
  padding: 5px 10px;
  padding: 1px 5px;
  font-size: 12px;
  line-height: 1.5;
  border-radius: 3px;
}


/* line 4956, display */

.thumbnail {
  display: inline-block;
  display: block;
  height: auto;
  max-width: 100%;
  padding: 4px;
  line-height: 1.428571429;
  background-color: #ffffff;
  border: 1px solid #dddddd;
  border-radius: 4px;
  -webkit-transition: all 0.2s ease-in-out;
          transition: all 0.2s ease-in-out;
}

Thx
@cvrebert
Copy link
Collaborator

cvrebert commented Oct 8, 2013

Confirmed that this is still present in latest master.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 8, 2013

The .btn-group-xs problem ends up being due to less/buttons.less:

.btn-sm,
.btn-xs {
  /* line-height: ensure proper height of button next to small input */
  .button-size(@padding-small-vertical; @padding-small-horizontal; @font-size-small; @line-height-small; @border-radius-small);
}
.btn-xs {
  padding: 1px 5px; /* PROBLEM!: .button-size ABOVE ALSO SETS padding*/
}

We should probably separate the .btn-xs and .btn-sm declarations and have .btn-xs use its own .button-size invocation. And we might wanna add vars for the 1px & 5px padding amounts, instead of hardcoding them.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 8, 2013

Short of some LESS trick, I don't know if the .thumbnail problem is avoidable:

/* less/thumbnails.less */
.thumbnail {
  .img-thumbnail();
  display: block; // Override the inline-block from `.img-thumbnail`

@mdo mdo closed this as completed in e484828 Nov 30, 2013
@mdo mdo mentioned this issue Nov 30, 2013
Closed
cvrebert added a commit that referenced this issue Dec 4, 2013
@cvrebert
fix .btn-group-xs portion of #10979
4a45650
@cvrebert cvrebert mentioned this issue Dec 4, 2013
Merged
mdo added a commit that referenced this issue Dec 4, 2013
@mdo
Merge pull request #11697 from twbs/btn-xs-10979
ed0d556 
fix .btn-group-xs portion of #10979
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
@mdo
(less) Fix twbs#10979: Don't use .img-thumbnail as a mixin for .thumb…
7628109 
…nail to avoid dupe and unnecessary styles
stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
@cvrebert
(less) fix .btn-group-xs portion of twbs#10979
37cb0d8
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fix twbs#10979: Don't use .img-thumbnail as a mixin for .thumb…
fd4f6b1 
…nail to avoid dupe and unnecessary styles
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@cvrebert
(less) fix .btn-group-xs portion of twbs#10979
e16eec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed css
Projects
None yet
Milestone
v3.0.3
Development

No branches or pull requests
2 participants
@ujovlado @cvrebert