Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Change .divider to .disabled on keydown event. #15147

Closed
vsn4ik opened this issue Nov 15, 2014 · 1 comment
Closed

Dropdown: Change .divider to .disabled on keydown event. #15147

vsn4ik opened this issue Nov 15, 2014 · 1 comment
Labels
js
Milestone
v3.3.4

Comments

@vsn4ik
Copy link
Contributor

vsn4ik commented Nov 15, 2014

bootstrap/js/dropdown.js

Line 75 in ac49a09

var desc = ' li:not(.divider):visible a'

  1. .divider never includes a.
  2. I believe it is necessary to replace .divider to .disabled.

Current behavior: http://getbootstrap.com/components/#dropdowns-disabled.
Pure select skips disabled option: http://jsbin.com/demeqizefi/1/edit?html,output.
@cvrebert cvrebert added the js label Nov 16, 2014
@hnrch02 hnrch02 added this to the v3.3.2 milestone Nov 17, 2014
@ankurkaushal
Copy link

@cvrebert Should I go ahead and submit and pull request for it? @vsn4ik's suggestion works and it was quite a minor fix.

ankurkaushal pushed a commit to ankurkaushal/bootstrap that referenced this issue Dec 3, 2014
Change divider class to disabled on keydown event twbs#15147
c49d8a9
@ankurkaushal ankurkaushal mentioned this issue Dec 3, 2014
Closed
@vsn4ik vsn4ik mentioned this issue Jan 8, 2015
Closed
@mdo mdo modified the milestones: v3.3.2, v3.3.3 Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js
Projects
None yet
Milestone
v3.3.4
5 participants
@mdo @cvrebert @hnrch02 @ankurkaushal @vsn4ik