Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document .text-gray-dark class #21761

Closed
Quy opened this issue Jan 17, 2017 · 2 comments
Closed

Document .text-gray-dark class #21761

Quy opened this issue Jan 17, 2017 · 2 comments
Labels
docs v4
Milestone
v4.0.0-beta

Comments

@Quy
Copy link
Contributor

Quy commented Jan 17, 2017

Ref #19847
@pvdlg
Copy link
Contributor

pvdlg commented Jan 17, 2017

Actually I wonder is text-gray-dark shouldn't be removed ?

The reason for adding it what to overwrite the default color: #fff on classes bg-* : #19842
But in alpha-6 the classes bg-* do not define a default color attribute anymore. The bg-* are now meant to be used with text-*.
So gray-dark is now the default color on an element with bg-*.

@mdo mdo modified the milestone: v4.0.0-beta.2 Jan 21, 2017
@Quy
Copy link
Contributor Author

Quy commented Jan 23, 2017

@vanduynslagerp Maybe not per this use case #21803.

@mdo mdo modified the milestones: v4.0.0-beta, v4.0.0-beta.2 Mar 28, 2017
@mdo mdo closed this as completed in b3cad39 Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
4 participants
@mdo @Quy @bardiharborow @pvdlg