Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms - Danger SVG $red color propagate #21908

Closed
silverbackdan opened this issue Feb 3, 2017 · 0 comments
Closed

Forms - Danger SVG $red color propagate #21908

silverbackdan opened this issue Feb 3, 2017 · 0 comments
Labels
css has-pr v4
Milestone
v4.0.0-beta

Comments

@silverbackdan
Copy link

silverbackdan commented Feb 3, 2017 •
edited

Bootstrap 4 Alpha 6 - When $red scss variable changed, colour only propagates to the danger SVG fill and not the stroke.

_variables.scss line 559 is:

$form-icon-danger: str-replace(url("data:image/svg+xml;charset=utf8,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='#{$form-icon-danger-color}' viewBox='-2 -2 7 7'%3E%3Cpath stroke='%23d9534f' d='M0 0l3 3m0-3L0 3'/%3E%3Ccircle r='.5'/%3E%3Ccircle cx='3' r='.5'/%3E%3Ccircle cy='3' r='.5'/%3E%3Ccircle cx='3' cy='3' r='.5'/%3E%3C/svg%3E"), "#", "%23") !default;

and I think should be:

$form-icon-danger: str-replace(url("data:image/svg+xml;charset=utf8,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='#{$form-icon-danger-color}' viewBox='-2 -2 7 7'%3E%3Cpath stroke='#{$form-icon-danger-color}' d='M0 0l3 3m0-3L0 3'/%3E%3Ccircle r='.5'/%3E%3Ccircle cx='3' r='.5'/%3E%3Ccircle cy='3' r='.5'/%3E%3Ccircle cx='3' cy='3' r='.5'/%3E%3C/svg%3E"), "#", "%23") !default;
  • Adjusted stroke='%23d9534f' to stroke='#{$form-icon-danger-color}'
@mdo mdo added this to the v4.0.0-beta milestone Feb 4, 2017
@mdo mdo added the has-pr label Feb 4, 2017
@mdo mdo closed this as completed in 09c7b1c Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
3 participants
@mdo @bardiharborow @silverbackdan