Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Docs for Customizing Grid Breakpoints #22133

Closed
jpulec opened this issue Mar 7, 2017 · 0 comments
Closed

Incorrect Docs for Customizing Grid Breakpoints #22133

jpulec opened this issue Mar 7, 2017 · 0 comments
Labels
docs has-pr v4
Milestone
v4.0.0-beta

Comments

@jpulec
Copy link

jpulec commented Mar 7, 2017

The docs for customizing grid breakpoints show 3 tiers, with the following.

$grid-breakpoints: (
  sm: 480px,
  md: 768px,
  lg: 1024px
);

However this will result in a warning since bootstrap checks that the first $grid-breakpoint starts with zero after the introduction of #19308. The docs should probably be corrected to indicate this.
@mdo mdo modified the milestones: v4.0.0-beta, v4.0.0-beta.2 Mar 8, 2017
@mdo mdo modified the milestones: v4.0.0-beta, v4.0.0-beta.2 Mar 26, 2017
@mdo mdo added the has-pr label Mar 26, 2017
mdo added a commit that referenced this issue Mar 26, 2017
@mdo
fixes #22133
1dd73d0
@mdo mdo mentioned this issue Mar 26, 2017
Merged
4 tasks
@mdo mdo closed this as completed in 1e6902d Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs has-pr v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
2 participants
@mdo @jpulec