Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form controls docs #22244

Closed
matsaman opened this issue Mar 22, 2017 · 4 comments
Closed

Form controls docs #22244

matsaman opened this issue Mar 22, 2017 · 4 comments
Labels
docs has-pr v4
Projects
v4 Beta 1
Milestone
v4.0.0-beta

Comments

@matsaman
Copy link

https://v4-alpha.getbootstrap.com/components/forms/#form-controls
Remember, since Bootstrap utilizes the HTML5 doctype, all inputs must have a type attribute.

I don't know whether bootstrap requires this, but HTML5 certainly does not:
http://w3.org/tr/html5/forms.html#attr-input-type
@ghost
Copy link

ghost commented Mar 23, 2017

I don't see what your point is here?

Regardless whether it's required or not, you still need a type to determine the input. I've never seen anyone leave the type blank (which defaults to a text box).

@bkdotcom
Copy link
Contributor

bkdotcom commented Mar 23, 2017 •
edited

I don't see what your point is here?

His point is "the HTML5 doctype requires all inputs to have a type attribute" is patently false.

I've never seen anyone leave the type blank

anecdotal

you still need a type to determine the input

the default type is "text"

(which defaults to a text box)

exactly, type is NOT required

@mdo
Copy link
Member

mdo commented Mar 23, 2017

This was added to our docs long ago after situations like #170, #246, and #4089.

@bkdotcom
Copy link
Contributor

Since bootstrap no longer uses the input[type="text"] selector, I don't think this still applies?

@mdo mdo added this to the v4.0.0-beta milestone Apr 16, 2017
@mdo mdo added the has-pr label Apr 16, 2017
@mdo mdo added this to In progress in v4 Beta 1 May 26, 2017
@mdo mdo moved this from In progress to Safe to merge in v4 Beta 1 May 27, 2017
@mdo mdo closed this as completed in b21b83b Jun 15, 2017
@mdo mdo moved this from Safe to merge to Shipped in v4 Beta 1 Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs has-pr v4
Projects
No open projects
v4 Beta 1
Shipped
Milestone
v4.0.0-beta
Development

No branches or pull requests
4 participants
@mdo @Johann-S @bkdotcom @matsaman