Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units tests failed on OSX and Linux #22332

Closed
Johann-S opened this issue Apr 2, 2017 · 7 comments
Closed

Units tests failed on OSX and Linux #22332

Johann-S opened this issue Apr 2, 2017 · 7 comments
Labels
js v4

Comments

@Johann-S
Copy link
Member

Johann-S commented Apr 2, 2017 •
edited

Due to this commit a14451d

job : https://travis-ci.org/twbs/bootstrap/jobs/217756286

Maybe @deilv, do you have any idea why ?

Edit maybe it would be better to move unit test relative to this commit in a visuel unit test
@Johann-S Johann-S added the v4 label Apr 2, 2017
@deilv
Copy link
Contributor

deilv commented Apr 2, 2017

All tests passed before the merge, will look into it asap

@deilv
Copy link
Contributor

deilv commented Apr 2, 2017

I just successfully built on Linux, no errors whatsoever. Maybe Travis is acting up again? Will test on macOS in a few minutes.

@deilv
Copy link
Contributor

deilv commented Apr 2, 2017 •
edited

Builds fine on macOS, too. I also synced my forked repository and travis tested fine. I am trying to figure out why they fail on twbs.

@deilv
Copy link
Contributor

deilv commented Apr 2, 2017

I found the issue, PR coming up. The modal works great, but the test has to take into account macOS behaviour.

@Johann-S
Copy link
Member Author

Johann-S commented Apr 2, 2017

Thank you @deilv 👍
When you'll open your PR I'll create a temporary branch on BS repository to test on SauceLabs via Travis

@deilv deilv mentioned this issue Apr 2, 2017
Merged
@deilv
Copy link
Contributor

deilv commented Apr 2, 2017

@Johann-S @mdo The PR with the fix should be ready to merge and resolve all build errors. I'm sorry for the trouble, but I really doubt I could predict such an exotic issue :)

@Johann-S
Copy link
Member Author

Johann-S commented Apr 3, 2017

Don't worry it's ok 👍 it's hard to test on multi OS

@Johann-S Johann-S added the js label Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deilv @Johann-S