Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small error in documentation (responsive utilities) #22968

Closed
KrisGielen opened this issue Jul 2, 2017 · 5 comments
Closed

Small error in documentation (responsive utilities) #22968

KrisGielen opened this issue Jul 2, 2017 · 5 comments
Labels
docs v4

Comments

@KrisGielen
Copy link

Unless I don't understand how it works, I think there is a small error in the one but last paragraph of https://github.com/twbs/bootstrap/blob/v4-dev/docs/4.0/migration.md#responsive-utilities
It states:

You can combine one .d--none class with one .d--block class to show an element only on a given interval of screen sizes (e.g. .d-none.d-md-block.d-lg-none shows the element only on medium and large devices).

However, I think it should read:

You can combine one .d--none class with one .d--block class to show an element only on a given interval of screen sizes (e.g. .d-none.d-md-block.d-xl-none shows the element only on medium and large devices).
@mdo
Copy link
Member

mdo commented Jul 2, 2017

The paragraph is correct as-is.

With .d-none.d-md-block.d-lg-none, the element is hidden to start, hidden at sm, shown at md, and hidden again at lg and up (xl).

@mdo mdo closed this as completed Jul 2, 2017
@KrisGielen
Copy link
Author

KrisGielen commented Jul 2, 2017 •
edited

@mdo exactly, but the statement says "shows the element only on medium and large devices). As you rightfully state, the current .d-none.d-md-block.d-lg-none does not show it on large devices.
The example is about "a given interval of screen sizes", so therefore I think it still should be d-none.d-md-block.d-xl-none.

@istratos
Copy link

istratos commented Jul 2, 2017

While we understand how the classes work, I too believe the paragraph is not right.

Read carefully: (e.g. .d-none.d-md-block.d-lg-none shows the element only on medium and large devices).

It should be fixed to "shows the element only on medium devices)."

Or update d.none.d-md-block.d-xl-none to match the description. Either fix the classes or fix the description.

@mdo
Copy link
Member

mdo commented Jul 2, 2017

Oh shit, totally missed that part.

@mdo mdo reopened this Jul 2, 2017
@mdo mdo closed this as completed in 6cf1a10 Jul 2, 2017
@KrisGielen
Copy link
Author

Thx! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdo @Johann-S @KrisGielen @istratos