Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap v4 Beta 1 - no 'push' or 'pull' classes #23464

Closed
DaleMckeown opened this issue Aug 15, 2017 · 4 comments
Closed

Bootstrap v4 Beta 1 - no 'push' or 'pull' classes #23464

DaleMckeown opened this issue Aug 15, 2017 · 4 comments
Labels
docs v4
Projects
v4 Beta 2

Comments

@DaleMckeown
Copy link

DaleMckeown commented Aug 15, 2017 •
edited

There are no 'push' or 'pull' classes, within Bootstrap, on the contrary to the documentation.

There should be classes such as 'push-md-6' and 'pull-md-6', but they are completely omitted from the implementation, despite being specified in the documentation:

image

Test case:

 <nav class="col-12 navbar navbar-expand-md">
    <ul class="col-md-6 push-md-6 navbar-nav justify-content-end">
        <li class="nav-item nav-link">Should be far right</li>
    </ul>
    <ul class="col-md-6 pull-md-6 navbar-nav justify-content-start">
        <li class="nav-item nav-link">Should be far left</li>
    </ul>
</nav>
@jdinh-mackevision
Copy link

Sass mixins are gone also

@gijsbotje
Copy link
Contributor

@jdinh-mackevision which page did you find that excert? i couldn't locate it here https://getbootstrap.com/docs/4.0/layout/grid/

@XhmikosR
Copy link
Member

@gijsbotje https://getbootstrap.com/docs/4.0/migration/#grid-system-1

@mdo mdo added the docs label Aug 15, 2017
@mdo
Copy link
Member

mdo commented Aug 15, 2017

Push and pull were dropped for order. Updating the migration page in v4-dev now.

@mdo mdo closed this as completed in 62a3e9c Aug 15, 2017
@XhmikosR XhmikosR removed the css label Aug 15, 2017
@mdo mdo added this to Shipped in v4 Beta 2 Aug 20, 2017
@twbs twbs deleted a comment from wadmoy Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4
Projects
No open projects
v4 Beta 2
Shipped
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mdo @XhmikosR @DaleMckeown @gijsbotje @jdinh-mackevision