Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar responsive state is broken #23926

Closed
andresgalante opened this issue Sep 12, 2017 · 2 comments
Closed

Navbar responsive state is broken #23926

andresgalante opened this issue Sep 12, 2017 · 2 comments

Comments

@andresgalante
Copy link
Collaborator

andresgalante commented Sep 12, 2017 •
edited

The navbar is broken on v4-dev on a mobile size :

screen shot 2017-09-12 at 1 41 01 pm

it was introduced on this PR: #23652

flex-grow: 1 makes element to grow, it will not wrap.

I am working on it, finding a solution that also works on IE, I'll send a PR soon
@Fouzyyyy
Copy link

Fouzyyyy commented Sep 12, 2017 •
edited

Hi @andresgalante,

I would like to work on this one. I tried to reproduce it but I couldn't. Could you tell us more about this behavior? browser? version? and what break-point?

@andresgalante andresgalante mentioned this issue Sep 12, 2017
Merged
@andresgalante
Copy link
Collaborator Author

andresgalante commented Sep 12, 2017 •
edited

@Fouzyyyy sorry, I've already sent a PR, the bug is on v4-dev branch

@Fouzyyyy Fouzyyyy mentioned this issue Sep 12, 2017
Closed
andresgalante added a commit to andresgalante/bootstrap that referenced this issue Sep 13, 2017
@andresgalante
fixes twbs#23926 responsive state on navbar
5becfa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andresgalante @Fouzyyyy