Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Incorrectly States when a Breakpoint Transition will Occur #25280

Closed
sirsavary opened this issue Jan 12, 2018 · 1 comment
Closed

Documentation Incorrectly States when a Breakpoint Transition will Occur #25280

sirsavary opened this issue Jan 12, 2018 · 1 comment
Labels
docs v4
Projects
v4.0 stable

Comments

@sirsavary
Copy link

sirsavary commented Jan 12, 2018 •
edited

From https://getbootstrap.com/docs/4.0/layout/grid/#stacked-to-horizontal:

Using a single set of .col-sm-* classes, you can create a basic grid system that starts out stacked on extra small devices before becoming horizontal on desktop (medium) devices.

The docs incorrectly state that the grid system will become horizontal on a medium device or larger when it will actually transition on a small device or larger.

Pretty simple fix, will create a PR as long as this wasn't intentional.
@mdo mdo added this to Inbox in v4.0 stable via automation Jan 16, 2018
@mdo mdo closed this as completed in b5039d5 Jan 16, 2018
v4.0 stable automation moved this from Inbox to Shipped Jan 16, 2018
@sirsavary
Copy link
Author

Hey @mdo, there's a typo in your fix:

Using a single set of .col-sm-* classes, you can create a basic grid system that starts out stacked before becoming horizontal with at the small breakpoint (sm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4
Projects
No open projects
v4.0 stable
  
Shipped
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirsavary @Johann-S