Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4 $table-hover-color option needed #26465

Closed
WilliamStam opened this issue May 8, 2018 · 0 comments
Closed

v4 $table-hover-color option needed #26465

WilliamStam opened this issue May 8, 2018 · 0 comments
Labels
css has-pr v4

Comments

@WilliamStam
Copy link

WilliamStam commented May 8, 2018 •
edited

hiya, busy theming bootstrap for my app. previously i did something like add my own class to a table and theme that class but this time im using the variables to get bootstrap itself to be themed.

as is now:

$table-cell-padding:          .75rem !default;
$table-cell-padding-sm:       .3rem !default;

$table-bg:                    transparent !default;
$table-accent-bg:             rgba($black, .05) !default;
$table-hover-bg:              rgba($black, .075) !default;
$table-active-bg:             $table-hover-bg !default;

$table-border-width:          $border-width !default;
$table-border-color:          $gray-300 !default;

$table-head-bg:               $gray-200 !default;
$table-head-color:            $gray-700 !default;

$table-dark-bg:               $gray-900 !default;
$table-dark-accent-bg:        rgba($white, .05) !default;
$table-dark-hover-bg:         rgba($white, .075) !default;
$table-dark-border-color:     lighten($gray-900, 7.5%) !default;
$table-dark-color:            $body-bg !default;

$table-striped-order:         odd !default;

$table-caption-color:         $text-muted !default;

i propose the addition of

$table-hover-color: $body-color !default;

as soon as you make the hover a darker colour for instance being able to change the fonts colour is quite important.

its easy enough to add into my custom css but it might break stuff regarding the different primary, secondary, info etc context classes

changes needed:
add $table-hover-color: $body-color !default; to _variables.scss
add color:$table-hover-color to _tables.scss line 93

bootstrap 4.1
@mdo mdo added this to Inbox in v4.2 via automation May 10, 2018
@mdo mdo removed this from Inbox in v4.2 Oct 7, 2018
@mdo mdo added this to Inbox in v4.3 via automation Dec 15, 2018
@mdo mdo added the has-pr label Dec 15, 2018
@mdo mdo mentioned this issue Dec 15, 2018
Merged
@mdo mdo moved this from Inbox to Ready to merge in v4.3 Dec 17, 2018
@mdo mdo closed this as completed in 3b42a9e Dec 21, 2018
v4.3 automation moved this from Ready to merge to Shipped Dec 21, 2018
mdo added a commit that referenced this issue Dec 21, 2018
@mdo
Add table-hover-color variables (#27850)
2e1d0fe 
* Add table-hover-color variables
Fixes #26465

* Put $table-color to use outside _variables.scss
@XhmikosR XhmikosR removed this from Shipped in v4.3 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdo @WilliamStam