Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card Columns is badly structured #26586

Closed
Vimal-Raghubir opened this issue May 24, 2018 · 4 comments
Closed

Card Columns is badly structured #26586

Vimal-Raghubir opened this issue May 24, 2018 · 4 comments
Labels
docs has-pr v4
Projects
v4.1.2

Comments

@Vimal-Raghubir
Copy link

In the Documentation / Components / Cards > Card columns section, there is a duplicate section in the second column and in the third column the card title box is in the wrong position. It should be connected to the image like the two previous columns.
@Vimal-Raghubir Vimal-Raghubir mentioned this issue May 24, 2018
Closed
@coliff
Copy link
Contributor

coliff commented May 29, 2018

I thought the example was designed intentionally like that to show how different size and style cards can work together in columns.

As it mentions in the introduction - it allows for Masonry-like columns. See the site for examples: https://masonry.desandro.com/

@Vimal-Raghubir
Copy link
Author

I agree however there was a duplicate card column below the existing one in column 2 which I removed. As well as the other card column wasn't placed inside the card's body making it detached from the card itself. So I fixed that.

@Vimal-Raghubir
Copy link
Author

old look

As you can see the card column that has the black outline is a duplicate of the card column above and the red column is the one that had to be placed into the card body like the 2 sections before it.

mdo added a commit that referenced this issue Jul 9, 2018
@mdo
update card columns docs to make copy more accurate
d747736 
closes #26586, closes #26587
@mdo
Copy link
Member

mdo commented Jul 9, 2018

Fix coming in #26732.

@mdo mdo added the has-pr label Jul 9, 2018
@mdo mdo added this to Inbox in v4.1.2 via automation Jul 9, 2018
XhmikosR pushed a commit that referenced this issue Jul 9, 2018
@mdo @XhmikosR
update card columns docs to make copy more accurate
5e73fc8 
closes #26586, closes #26587
@mdo mdo moved this from Inbox to Needs review in v4.1.2 Jul 12, 2018
XhmikosR pushed a commit that referenced this issue Jul 12, 2018
@mdo @XhmikosR
update card columns docs to make copy more accurate
2026919 
closes #26586, closes #26587
@mdo mdo closed this as completed in de7bef8 Jul 12, 2018
v4.1.2 automation moved this from Needs review to Shipped Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs has-pr v4
Projects
No open projects
v4.1.2
  
Shipped
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdo @coliff @Johann-S @Vimal-Raghubir