build: add a script to check font JSON for differences with SVGs #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korki43
force-pushed
the
check-json-file
branch
from
795bcd9
to
05dfb7f
Compare
XhmikosR
force-pushed
the
check-json-file
branch
from
174dedb
to
de4ea0f
Compare
|
Nice one, thank you @korki43 as usual ❤️ I only had to make a few minor changes 🙂 Let me know what you think, otherwise we can merge |
XhmikosR
reviewed
Mar 27, 2023
build/check-json.js
Outdated
|
|
||
| throw new Error('Mismatch between JSON and SVG files') |
There was a problem hiding this comment.
I had to drop this @korki43, it didn't seem to work right for some reason.
XhmikosR
approved these changes
Mar 27, 2023
XhmikosR
changed the title
XhmikosR
changed the title
This was referenced May 20, 2024
This was referenced May 24, 2024
This was referenced Jun 1, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1640.
Unsure which npm script this would belong to, so I didn't add it to so far.