Provide a minified font CSS file too #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/font-css-min
branch
2 times, most recently
from
d038b91
to
fa856f6
Compare
XhmikosR
force-pushed
the
xmr/font-css-min
branch
from
fc7f38e
to
6d49aac
Compare
XhmikosR
force-pushed
the
xmr/font-css-min
branch
from
6d49aac
to
a067068
Compare
This was referenced May 20, 2024
This was referenced May 24, 2024
This was referenced Jun 1, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1076
See #1076 (comment) for a size comparison.
The gains after compression are negligible (see the above link), but anyway, it doesn't cost us a lot, I suppose. I expect +~15 KB in the npm package, since tarballs are compressed, +~82 KB size on disk and 1 more file.
Note that I didn't change the package.json
stylesto point to the minified file like we do in bootstrap.