Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add paper plane tag to send icons #1713

Merged
merged 4 commits into from Sep 12, 2023
Merged

Add paper plane tag to send icons #1713

merged 4 commits into from Sep 12, 2023

Conversation

tjkuson
Copy link
Contributor

@tjkuson tjkuson commented May 2, 2023 •
edited

Addresses #1709 by adding 'plane' and 'paper' tags to the send icons.

@XhmikosR XhmikosR requested a review from mdo May 17, 2023 05:59
@XhmikosR XhmikosR added the docs Improvements or additions to documentation label May 17, 2023
mdo
mdo requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wrong to label these as planes instead of "paper planes"

docs/content/icons/send-check-fill.md Outdated Show resolved Hide resolved
@tjkuson tjkuson requested a review from mdo August 17, 2023 19:32
@tjkuson tjkuson changed the title Add tags to send icons Add paper plane tag to send icons Aug 17, 2023
@mdo mdo merged commit ffc783b into twbs:main Sep 12, 2023
9 checks passed
@tjkuson tjkuson mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
No open projects
Icons v1.11.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tjkuson @mdo @XhmikosR