Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lookup functions names #477

Closed
chimeno opened this issue Aug 13, 2014 · 5 comments
Closed

Refactor lookup functions names #477

chimeno opened this issue Aug 13, 2014 · 5 comments
Labels
Improvement This is regarding an improvement to an existing feature
Milestone

Comments

@chimeno
Copy link
Contributor

chimeno commented Aug 13, 2014

Currently there are at least three function for lookup bulk data: statuses, friendship and users.
Meanwhile two of them are called: lookup_friendshipand lookup_users the other one is called statuses_lookup. code.
I think is a good idea having all three in the same way, although we can fall in backward incompatibility, unless we proved a fallback.

Just saying.

@Aaron1011
Copy link
Contributor

@chimeno: I agree. Which way do you think it should be? (changing statuses_lookup to lookup_statuses, or changing lookup_users and lookup_friendship? The lookup_friendship style looks better to me, but statuses_lookup is more consistent with the actual API structure.

@chimeno
Copy link
Contributor Author

chimeno commented Aug 13, 2014

I'd go with the statuses_lookup approach due to it's more consistent with the actual API and with de twitter docs and urls, because the url is statuses/lookuplink.
Sorry for not coding a PR, right now I'm pretty busy but I'll try it.

@Aaron1011 Thanks for considering my opinion.

@ouattararomuald
Copy link

I agree with refactoring but just renaming functions will break compatibility between existing versions and upcoming. What i suggest is to mark existing functions with a decorator like Java's @deprecated which is used to explain why the method was deprecated and to suggest an alternative.

@teoguso

This comment has been minimized.

@Harmon758

This comment has been minimized.

@Harmon758 Harmon758 added the Improvement This is regarding an improvement to an existing feature label Apr 27, 2019
@Harmon758 Harmon758 added this to the 4.0 milestone Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement This is regarding an improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants