Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I sign up through Google, I see my Google profile picture on Twenty #212

Closed
FelixMalfait opened this issue Jun 7, 2023 · 0 comments · Fixed by #964
Closed

When I sign up through Google, I see my Google profile picture on Twenty #212

FelixMalfait opened this issue Jun 7, 2023 · 0 comments · Fixed by #964
Assignees
Labels
good first issue Good for newcomers scope: backend Issues that are affecting the backend side only

Comments

@FelixMalfait
Copy link
Member

FelixMalfait commented Jun 7, 2023

We are already retrieving email, first name, last name from google.
We could also retrieve profile picture.

The profile picture will come as an URL, if we store it directly in our DB this won't work because we are currently storing relative path to our own storage in backend
I see two alternatives:

  • enable to store absolute path in back-end, in this case, we need to introduce a picture table with type 'absolute' | 'relative' and link it to workspace / user. We then need to update frontend accordingly or have the server always send the absolute URL
  • fetch the Image URL and re-upload the image in our own backend.

To keep it simple, I would go for the second option :
https://stackoverflow.com/questions/18264346/how-to-load-an-image-from-url-into-buffer-in-nodejs

@FelixMalfait FelixMalfait added the scope: backend Issues that are affecting the backend side only label Jun 7, 2023
@Bonapara Bonapara added this to the 0.1 - Alpha Release 🐣 milestone Jun 7, 2023
@Bonapara Bonapara removed the On Github label Jun 7, 2023
@Bonapara Bonapara changed the title [T-328] I have a full name and profile picture pulled through Google I have a full name and profile picture pulled through Google Jun 7, 2023
@charlesBochet charlesBochet changed the title I have a full name and profile picture pulled through Google When I sign up through Google, I see my Google profile picture on Twenty Jul 12, 2023
@charlesBochet charlesBochet added the good first issue Good for newcomers label Jul 12, 2023
@charlesBochet charlesBochet assigned magrinj and unassigned thaisguigon Jul 17, 2023
@magrinj magrinj linked a pull request Jul 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: backend Issues that are affecting the backend side only
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants