Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Chips should have an ellipsis if their name is overflowing their max-width #301

Closed
Tracked by #428
lucasbordeau opened this issue Jun 15, 2023 · 6 comments
Closed
Tracked by #428
Assignees

Comments

@lucasbordeau
Copy link
Contributor

Since entity chips can have different max width, whether they are used in a table cell or a entity picker, they should handle themselves the text that is overflowing the max width.

We should also find a way to fix their max width :

  • Have separate components wrapping a generic EntityChip component
  • Giving width or max-width in a props
@lucasbordeau lucasbordeau changed the title Entity Chips should have an ellipsis if their name is overflowing their max-width Entity Chips should have an ellipsis if their name if overflowing their max-width Jun 15, 2023
@lucasbordeau lucasbordeau changed the title Entity Chips should have an ellipsis if their name if overflowing their max-width Entity Chips should have an ellipsis if their name is overflowing their max-width Jun 15, 2023
@Bonapara
Copy link
Member

We should crop the content with [...] when the content is overflowing (Don't wrap content)

@charlesBochet
Copy link
Member

image

@magrinj magrinj self-assigned this Jun 26, 2023
@magrinj magrinj mentioned this issue Jun 26, 2023
3 tasks
@magrinj
Copy link
Member

magrinj commented Jun 26, 2023

@Bonapara To fix this, I had to made some change so the text field for companies will never go behind the comment chip, it's in #428

@Bonapara
Copy link
Member

@lucasbordeau cannot the comment chip be in position absolute above the text?

@magrinj
Copy link
Member

magrinj commented Jun 27, 2023

@Bonapara Yes it can, but if you put ellipsis this one is not going to be visible and hide by the comment button.
Seems it's more a design problem actually, for now when it's too long the text is cut before the CommentChip with an ellipsis

@charlesBochet
Copy link
Member

Fixed by #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants