Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform the Show Back button into a Close button #4454

Closed
Bonapara opened this issue Mar 13, 2024 · 5 comments
Closed

Transform the Show Back button into a Close button #4454

Bonapara opened this issue Mar 13, 2024 · 5 comments
Assignees
@brkuhgk
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours

Comments

@Bonapara
Copy link
Member

Current Behavior

On Shows, the Back button mimics the browser's Back button functionality.

Current Behavior

Desired Behavior

We aim to replace the Back button with a Close button. Upon clicking, it should redirect users to the Index from which the show was accessed. If accessed outside of an index, it should default to the default index.

CleanShot 2024-03-13 at 15 17 58

Figma

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=9901-40976&mode=design&t=75yrmyKfqMepmFVt-11

Related issues

#4428
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours labels Mar 13, 2024
This was referenced Mar 13, 2024
Closed
Open
@brkuhgk
Copy link
Contributor

brkuhgk commented Mar 13, 2024

Hi, can I work on this Issue?

@Bonapara
Copy link
Member Author

Hi @brkuhgk, for sure, thanks for contributing!

@Jonathanlemon
Copy link
Contributor

Has this been resolved? If not I could work on it.

@Bonapara
Copy link
Member Author

Hi @Jonathanlemon, I think the PR is still under review!

@FelixMalfait
Copy link
Member

Closing to only keep master issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brkuhgk brkuhgk

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FelixMalfait @Bonapara @Jonathanlemon @brkuhgk