Using "+" as a filter is breaking the table view

[Weiko]

Bug Description

Special characters such as "+" have special meanings in Regex expressions. Using those in a filter breaks the filtering.

Expected behavior

Should filter with existing records regardless of the usage of special characters

Technical inputs

Check isMatchingStringFilter.

[greptile-apps]

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).
To address the issue with special characters such as '+' breaking the table view when used as a filter, you'll need to modify the isMatchingStringFilter function in /packages/twenty-front/src/modules/object-record/record-filter/utils/isMatchingStringFilter.ts. Specifically, for the like and ilike cases, where the input string is converted into a regex pattern, you should escape special regex characters to ensure they are treated as literals. Here's a suggested change for the like and ilike cases: javascript case stringFilter.like !== undefined: { const escapedPattern = stringFilter.like.replace(/[.*+?^${}()|[\]\]/g, '\\$&'); // Escapes special characters const regexPattern = escapedPattern.replace(/%/g, '.*'); const regexCaseSensitive = new RegExp(`^${regexPattern}$`); return regexCaseSensitive.test(value); } case stringFilter.ilike !== undefined: { const escapedPattern = stringFilter.ilike.replace(/[.*+?^${}()|[\]\]/g, '\\$&'); // Escapes special characters const regexPattern = escapedPattern.replace(/%/g, '.*'); const regexCaseInsensitive = new RegExp(`^${regexPattern}$`, 'i'); return regexCaseInsensitive.test(value); } This change adds a step to escape special regex characters in the like and ilike string filters before converting the '%' wildcard characters into '.*' for regex matching. This should allow special characters such as '+' to be used in filters without breaking the table view.

References

/packages/twenty-front/src/modules/object-record/record-filter/utils/isMatchingStringFilter.ts

Ask Greptile

[suman-somu]

It didn't got error but unexpected behaviour.
Screencast from 2024-05-29 18-08-31.webm

Edit: It's working now without any change. idk why it was not working before.
Screencast from 2024-05-29 21-03-44.webm

[FelixMalfait]

Thanks @suman-somu! I'm also unable to reproduce the issue so I will close this, it has probably been fixed...