Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field positionning on Record page #5500

Open
FelixMalfait opened this issue May 21, 2024 · 2 comments
Open

Fix field positionning on Record page #5500

FelixMalfait opened this issue May 21, 2024 · 2 comments
Assignees
Labels
T type: bug Something isn't working

Comments

@FelixMalfait
Copy link
Member

I just noticed we broke the positioning of input fields on the record show page:

Screenshot 2024-05-21 at 11 30 26

Ideally it should open exactly where the read-only text was. So if I the input is filled and I click on edit the text should really move.

Related: #5416

@FelixMalfait FelixMalfait added type: bug Something isn't working T labels May 21, 2024
Copy link

greptile-apps bot commented May 21, 2024

Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).

To fix the positioning of input fields on the Record show page, follow these steps:

  1. Open RecordShowPage.tsx and locate the component responsible for rendering the input fields.
  2. Open FieldInput.tsx and adjust the positioning logic to ensure the input field opens exactly where the read-only text was.
  3. Ensure the CSS styles in FieldInput.tsx match the positioning of the read-only text.

Example adjustment in FieldInput.tsx:

const FieldInput = styled.input`
  position: absolute;
  top: 0;
  left: 0;
  width: 100%;
  height: 100%;
  // Add any additional styles needed to match the read-only text positioning
`;

Ensure the input field's container in RecordShowPage.tsx has the correct relative positioning.

References

@thomtrp
Copy link
Contributor

thomtrp commented Jun 19, 2024

@FelixMalfait do you still see the bug? I cannot reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T type: bug Something isn't working
Projects
Status: 🔖 Planned
Development

No branches or pull requests

2 participants