Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI to Match Figma Specs: Labels, Buttons, Gaps #5910

Open
Bonapara opened this issue Jun 17, 2024 · 6 comments
Open

Update UI to Match Figma Specs: Labels, Buttons, Gaps #5910

Bonapara opened this issue Jun 17, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours

Comments

@Bonapara
Copy link
Member

Bonapara commented Jun 17, 2024

Current Behavior

  • Section labels are uppercase.
  • The "Esc to cancel" text helper should be removed.

CleanShot 2024-06-17 at 17 10 22

Desired Behavior

Match the following Figma design:

  • Replace the Esc to cancel helper with an X button.
  • Set the section labels to lowercase - except the first letter of course (use the same style as NavigationDrawerSectionTitle.tsx, and ideally the same component).
  • Add a gap between the first section label and the search bar.
  • Check if other details are matching

image

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours labels Jun 17, 2024
Copy link

greptile-apps bot commented Jun 17, 2024

Implementation Steps

  1. Update Section Labels:

    • Locate the section labels in the relevant component file.
    • Replace the current label implementation with the NavigationDrawerSectionTitle component from NavigationDrawerSectionTitle.tsx.
  2. Remove 'Esc to cancel' Helper:

    • Find the text helper displaying 'Esc to cancel' in the component file.
    • Remove this text helper.
  3. Add 'X' Button:

    • Add an 'X' button in place of the removed 'Esc to cancel' helper.
    • Ensure the button has the appropriate styling and functionality.
  4. Add Gap Between Section Label and Search Bar:

    • Locate the section containing the first section label and the search bar.
    • Add a CSS margin or padding to create the desired gap.

Relevant Files

  • NavigationDrawerSectionTitle.tsx for section label styling.
  • The component file containing the section labels and 'Esc to cancel' helper.

References

@sanidhyasin
Copy link
Contributor

hey @Bonapara, would love to work on this issue, please assign this to me.

@Bonapara
Copy link
Member Author

Sure @sanidhyasin, thanks for contributing!

@ehconitin
Copy link
Contributor

Could u assign this to me @Bonapara

@Bonapara
Copy link
Member Author

Sure @sanidhyasin, thanks for contributing!

@ehconitin
Copy link
Contributor

@Bonapara please check PR 6415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours
Projects
Status: 🔖 Planned
Development

No branches or pull requests

3 participants