Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for defaults in SCSS and correct fluid column calcs #26

Closed
wants to merge 3 commits into from
Closed

Fixes for defaults in SCSS and correct fluid column calcs #26

wants to merge 3 commits into from

Conversation

phil-quinn
Copy link

Hi,

I apologize if my pull request is not being done correctly. This is my first ever git-hub pull request.

The way the grid.scss works currently, doesn't work right if you are using sub-columns (inside a row) when in fluid mode. I've made some tweaks to hopefully fix that.

Also, I added some !default declarations to your defaults.

Thanks for putting this framework together! I really like how small and efficient it is!

I hope my changes are helpful.

@tylertate
Copy link
Owner

Hi Phil, thanks for your work. Your solution to the gridsystem-width worked, but @daffydowden had the idea of using a function instead, which is what I ended up implementing. Thanks again.

@tylertate tylertate closed this Jan 11, 2012
@phil-quinn
Copy link
Author

Thanks Tyler.

Actually, ultimately I found that the whole notion of percentage based
columns was flawed for what I was doing since different browsers
handle rounding differently, and I could never get complex columns to
line up right, or reliably fill the whole space.

I ended up building my own solution, using flexbox, that falls back to
pixel based columns for IE. I hope to publish it soon.

I was very much inspired by your system, and a number of others. Thank
you for all your hard work!

-Phil

On Wed, Jan 11, 2012 at 5:31 AM, Tyler Tate
reply@reply.github.com
wrote:

Hi Phil, thanks for your work. Your solution to the gridsystem-width worked, but @daffydowden had the idea of using a function instead, which is what I ended up implementing. Thanks again.


Reply to this email directly or view it on GitHub:
#26 (comment)

Phil Quinn, President, Quinn Interactive, Inc.
phil@quinn.com, (415) 296-9000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants