Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin can overwrite voice StatusUpdateUrl #57

Closed
mjg123 opened this issue Dec 10, 2021 · 1 comment
Closed

Plugin can overwrite voice StatusUpdateUrl #57

mjg123 opened this issue Dec 10, 2021 · 1 comment
Assignees

Comments

@mjg123
Copy link
Contributor

mjg123 commented Dec 10, 2021

We avoid overwriting existing config in the user's account by warning or preventing them from using a PN with existing config. We check for existing config by checking incoming SMS webhook URL and incoming call webhook URL, which the plugin would overwrite. The plugin also writes to the call statusCallbackUrl, but we never check that when we're looking for existing config.

@ayyrickay ayyrickay self-assigned this Apr 8, 2022
@ayyrickay
Copy link
Collaborator

Sorry - I took a while to wrap my head around this, but this config is only relevant on newly created call resources, correct? So there's no existing config to be concerned about, in this case. @mjg123 feel free to reopen if I'm missing something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants