Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
strip-js
dependency was used to sanitize theredirect_to
query parameter to thwart an XSS attack. It worked, but it is no longer maintained, and it brought along a number of additional dependencies, some of which have documented security vulnerabilities.The end-goal is to just ensure a valid URL is provided here, so we pass the string to the
URL()
constructor which will verify it's a valid URL as well as escape anything that might otherwise allow an XSS attack.Contributing to Twilio