Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable String values not correct in JSON specs? #84

Closed
Humancell opened this issue Jan 9, 2023 · 2 comments · Fixed by #85
Closed

Nullable String values not correct in JSON specs? #84

Humancell opened this issue Jan 9, 2023 · 2 comments · Fixed by #85
Labels
code-generation issue deals with generated code status: work in progress Twilio or the community is in the process of implementing

Comments

@Humancell
Copy link

Issue Summary

When importing the JSON specs into Postman and using them, there are numerous "issue" warnings that appear on various responses. Particularly the "meta" values for "next_page_url" and "previous_page_url", these are the most noticable.

It appears they are defined as a type of "String" rather that the supported array of "null or String": https://stackoverflow.com/questions/48111459/how-to-define-a-property-that-can-be-string-or-null-in-openapi-swagger

Steps to Reproduce

  1. Import a JSON spec into Postman
  2. Make an API call that includes meta paging properties in the response
  3. Look at the top of the Postman request tab and see the "Issues" warning(s)

Exception/Log

The response body property "meta.previous_page_url" must be string

Technical details:

  • twilio-oai version: 1.38.1
  • open version: 3.1
@twilio-dx
Copy link
Collaborator

Ahoy! Thank you for opening your first issue here! If this request is regarding troubleshooting your application, please reach out to the support team via https://support.twilio.com.

@isha689 isha689 added the status: help wanted requesting help from the community label Jan 10, 2023
@claudiachua claudiachua added code-generation issue deals with generated code status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels Jan 11, 2023
@claudiachua
Copy link
Contributor

Hi @Humancell , Thanks for bringing this to our attention. This issue has been added to our internal backlog to be prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation issue deals with generated code status: work in progress Twilio or the community is in the process of implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants