Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: append comment to the Response element #797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: append comment to the Response element #797

wants to merge 1 commit into from

Conversation

wsabol
Copy link

@wsabol wsabol commented Feb 28, 2024 •
edited

Fixes #796
Closes #796

Fixes

This PR allows you to append a xml comment to a VoiceResponse object.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@tiwarishubham635 tiwarishubham635 added the type: community enhancement feature request not on Twilio's roadmap label Apr 5, 2024
@tiwarishubham635
Copy link
Contributor

Hi @wsabol! I am taking a look at it

@tiwarishubham635
Copy link
Contributor

I can see the files VoiceResponse and Comment should be autogenerated from our internal tool yoyodyne as you can see the lines here. I will check what changes need to be done there for this. Thanks!

@tiwarishubham635
Copy link
Contributor

Created an internal ticket for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to add a comment in the twilio response
2 participants
@wsabol @tiwarishubham635