Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwiML not generating correctly with <Client></Client> tags. #162

Closed
phalt opened this issue Apr 7, 2014 · 2 comments
Closed

TwiML not generating correctly with <Client></Client> tags. #162

phalt opened this issue Apr 7, 2014 · 2 comments

Comments

@phalt
Copy link
Contributor

phalt commented Apr 7, 2014

When using this code:

r = Response()
    with r.dial(callerId=caller_id) as r:
        r.client('admin')
    return r.toxml()

The output is:

u'<?xml version="1.0" encoding="UTF-8"?><Dial callerId="XXXXXXXXXXX"><Client>admin</Client></Dial>'

The <Response> tags are missing!

selfie-1

@phalt
Copy link
Contributor Author

phalt commented Apr 7, 2014

Further to this, I've discovered that this code generates the XML perfectly fine:

r.dial(callerId='+XXXXXXXXXXX').client('test')

Output:

>>> r.toxml()
u'<?xml version="1.0" encoding="UTF-8"?><Response><Dial callerId="+447943511601"><Client>test</Client></Dial></Response>'

Documentation describes the previous methods for generating TwiML.

@phalt
Copy link
Contributor Author

phalt commented Aug 10, 2014

I believe the with statement does not work correctly with the dial tag. Investigation is needed to see if this is a bug across all methods and not just dial.

@phalt phalt self-assigned this Aug 27, 2014
@phalt phalt removed their assignment Dec 12, 2014
@carlosdp carlosdp closed this as completed Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants