Crash on disconnecting room

[rishabhja]

Description

App crashes when video activity is closed before any of the callbacks is fired (onConnectFailure, onConnected)

Steps to Reproduce

1. Start connecting to room
2. Close before any of the callbacks is fired for connection failure or disconnection

Expected Behavior

App should not crash

Actual Behavior

App crashes

Reproduces how Often

100%

Logs

 D/TwilioVideo: [Platform]:AndroidRoomObserver
D/TwilioVideo: [Core]:RoomSignalingImpl::RoomSignalingImpl()
D/TwilioVideo: [Platform]:Java_com_twilio_video_Room_nativeDisconnect
D/TwilioVideo: [Platform]:Java_com_twilio_video_Room_nativeDisconnect
D/TwilioVideo: [Platform]:Java_com_twilio_video_Room_nativeReleaseRoom
D/TwilioVideo: [Platform]:~AndroidRoomObserver
 D/TwilioVideo: [Core]:RoomSignalingImpl::~RoomSignalingImpl()
D/TwilioVideo: [Core]:RoomSignalingImpl: State transition successful: kInit -> kDisconnecting
 D/Room: onDisconnected()
D/TwilioVideo: [Core]:RoomSignalingImpl: State transition successful: kDisconnecting -> kDisconnected
D/TwilioVideo: [Platform]:Java_com_twilio_video_Room_nativeRelease
D/TwilioVideo: [Platform]:~RoomDelegate
A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 12964 (RoomNotifier - )
02-28 20:00:14.797 12985-12985/? A/DEBUG: pid: 11702, tid: 12964, name: RoomNotifier -  >>> to.go_internal <<<

Versions

All relevant version information for issue.

Video Android SDK

2.0.0-preview 5

Android API

26

Android Device

OnePlus 5, Xiaomi, Samsung S8, One plus 3T

[rishabhja]

Can you please provide any help on this? I am a paid user for twilio and need to release this at priority.

[aaalaniz]

Hey @rishabhja

Does the crash occur in the quickstart?

[rishabhja]

I have not tried it on that. But it does occur in my application

[aaalaniz]

Hey @rishabhja

Investigating a lead on this crash. I'll keep you posted.

Thanks!

[rishabhja]

I fixed it. It was crashing because i was calling room.disconnect 2 times. But still, i think it should not crash

[aaalaniz]

Hey @rishabhja

Yup you found it 😄

I'm working on a fix with a corresponding test. I'll keep you posted.

Thanks!

[rishabhja]

Sorry to ask it in this post. But does your sdk support accepting a custom logger instead of using Log.d? My app uses slf4j

[rishabhja]

Thanks for resolving the issue

[aaalaniz]

We do not support a custom log interface, but this seems like a reasonable feature request. Can you open a new Github issue with this enhancement? Thanks!

[rishabhja]

Will surely do that :). I am sorry to make this delayed request, but can you help me with the texture view issue I just opened

[aaalaniz]

Hey @rishabhja

This bug is resolved and going through internal testing. I will be shipping a fix on 1.x today and a 2.x fix first thing next week.

Thanks!

[aaalaniz]

Hey @rishabhja

This bug was fixed in 1.3.13 and 2.0.0-beta2.

Thanks for helping diagnose the issue!